GFS2: Get rid of dead code in inode_go_demote_ok
authorBob Peterson <rpeterso@redhat.com>
Fri, 1 Apr 2016 17:18:38 +0000 (13:18 -0400)
committerBob Peterson <rpeterso@redhat.com>
Tue, 5 Apr 2016 15:59:18 +0000 (11:59 -0400)
Function inode_go_demote_ok had some code that was only executed
if gl_holders was not empty. However, if gl_holders was not empty,
the only caller, demote_ok(), returns before inode_go_demote_ok
would ever be called. Therefore, it's dead code, so I removed it.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Acked-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/glops.c

index 437fd73e381e224063742284fd8f825d35b0e9db..5db59d44483809fa027196910a90d10536843c37 100644 (file)
@@ -286,17 +286,10 @@ static void inode_go_inval(struct gfs2_glock *gl, int flags)
 static int inode_go_demote_ok(const struct gfs2_glock *gl)
 {
        struct gfs2_sbd *sdp = gl->gl_name.ln_sbd;
-       struct gfs2_holder *gh;
 
        if (sdp->sd_jindex == gl->gl_object || sdp->sd_rindex == gl->gl_object)
                return 0;
 
-       if (!list_empty(&gl->gl_holders)) {
-               gh = list_entry(gl->gl_holders.next, struct gfs2_holder, gh_list);
-               if (gh->gh_list.next != &gl->gl_holders)
-                       return 0;
-       }
-
        return 1;
 }