ata: pata_of_platform: using of_property_read_u32() helper
authorKefeng Wang <wangkefeng.wang@huawei.com>
Tue, 24 Jan 2017 12:08:29 +0000 (20:08 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 24 Jan 2017 16:15:01 +0000 (11:15 -0500)
Using better of_property_read_u32() than generic of_get_property().

Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/pata_of_platform.c

index b6b7af894d9dae92a40d140554e7c0923a2c8a7d..201a32d0627fb5fd44d0b1abc9e87f605fd587b2 100644 (file)
@@ -32,7 +32,6 @@ static int pata_of_platform_probe(struct platform_device *ofdev)
        unsigned int reg_shift = 0;
        int pio_mode = 0;
        int pio_mask;
-       const u32 *prop;
 
        ret = of_address_to_resource(dn, 0, &io_res);
        if (ret) {
@@ -50,13 +49,9 @@ static int pata_of_platform_probe(struct platform_device *ofdev)
 
        irq_res = platform_get_resource(ofdev, IORESOURCE_IRQ, 0);
 
-       prop = of_get_property(dn, "reg-shift", NULL);
-       if (prop)
-               reg_shift = be32_to_cpup(prop);
+       of_property_read_u32(dn, "reg-shift", &reg_shift);
 
-       prop = of_get_property(dn, "pio-mode", NULL);
-       if (prop) {
-               pio_mode = be32_to_cpup(prop);
+       if (!of_property_read_u32(dn, "pio-mode", &pio_mode)) {
                if (pio_mode > 6) {
                        dev_err(&ofdev->dev, "invalid pio-mode\n");
                        return -EINVAL;