drm/exynos/ipp: remove temporary variable
authorAndrzej Hajda <a.hajda@samsung.com>
Thu, 3 Jul 2014 13:10:30 +0000 (15:10 +0200)
committerInki Dae <daeinki@gmail.com>
Sun, 3 Aug 2014 07:52:18 +0000 (16:52 +0900)
There is no reason to allocate intermediate variable.

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Inki Dae <inki.dae@samsung.com>
drivers/gpu/drm/exynos/exynos_drm_ipp.c

index f3d8b5cf3438b6d82a706506942cd8348358faed..f84ef8a905923cfa4f7ae452f70ef8eae138b834 100644 (file)
@@ -680,15 +680,14 @@ static struct drm_exynos_ipp_mem_node
                struct drm_exynos_ipp_queue_buf *qbuf)
 {
        struct drm_exynos_ipp_mem_node *m_node;
-       struct drm_exynos_ipp_buf_info buf_info;
+       struct drm_exynos_ipp_buf_info *buf_info;
        int i;
 
        m_node = kzalloc(sizeof(*m_node), GFP_KERNEL);
        if (!m_node)
                return ERR_PTR(-ENOMEM);
 
-       /* clear base address for error handling */
-       memset(&buf_info, 0x0, sizeof(buf_info));
+       buf_info = &m_node->buf_info;
 
        /* operations, buffer id */
        m_node->ops_id = qbuf->ops_id;
@@ -712,15 +711,14 @@ static struct drm_exynos_ipp_mem_node
                                goto err_clear;
                        }
 
-                       buf_info.handles[i] = qbuf->handle[i];
-                       buf_info.base[i] = *addr;
-                       DRM_DEBUG_KMS("i[%d]base[0x%x]hd[0x%x]\n",
-                               i, buf_info.base[i], (int)buf_info.handles[i]);
+                       buf_info->handles[i] = qbuf->handle[i];
+                       buf_info->base[i] = *addr;
+                       DRM_DEBUG_KMS("i[%d]base[0x%x]hd[0x%lx]\n", i,
+                                     buf_info->base[i], buf_info->handles[i]);
                }
        }
 
        m_node->filp = file;
-       m_node->buf_info = buf_info;
        mutex_lock(&c_node->mem_lock);
        list_add_tail(&m_node->list, &c_node->mem_list[qbuf->ops_id]);
        mutex_unlock(&c_node->mem_lock);