virtio: console: use vdev->priv to avoid accessing global var.
authorRusty Russell <rusty@rustcorp.com.au>
Mon, 18 Jan 2010 13:45:04 +0000 (19:15 +0530)
committerRusty Russell <rusty@rustcorp.com.au>
Wed, 24 Feb 2010 03:52:40 +0000 (14:22 +1030)
Part of removing our "one console" assumptions, use vdev->priv to point
to the port (currently == the global console).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/char/virtio_console.c

index df45e5e9a947502c98d9caf0342dadb54ef43c87..e52ee1151f5fdb8f27f80d4be8c3dcb8c66795c1 100644 (file)
@@ -187,6 +187,7 @@ static int get_chars(u32 vtermno, char *buf, int count)
  */
 static void virtcons_apply_config(struct virtio_device *dev)
 {
+       struct port *port = dev->priv;
        struct winsize ws;
 
        if (virtio_has_feature(dev, VIRTIO_CONSOLE_F_SIZE)) {
@@ -196,7 +197,7 @@ static void virtcons_apply_config(struct virtio_device *dev)
                dev->config->get(dev,
                                 offsetof(struct virtio_console_config, rows),
                                 &ws.ws_row, sizeof(u16));
-               hvc_resize(console.hvc, ws);
+               hvc_resize(port->hvc, ws);
        }
 }
 
@@ -219,7 +220,9 @@ static void notifier_del_vio(struct hvc_struct *hp, int data)
 
 static void hvc_handle_input(struct virtqueue *vq)
 {
-       if (hvc_poll(console.hvc))
+       struct port *port = vq->vdev->priv;
+
+       if (hvc_poll(port->hvc))
                hvc_kick();
 }
 
@@ -272,7 +275,10 @@ static int __devinit virtcons_probe(struct virtio_device *vdev)
                         "Multiple virtio-console devices not supported yet\n");
                return -EEXIST;
        }
+
+       /* Attach this port to this virtio_device, and vice-versa. */
        port->vdev = vdev;
+       vdev->priv = port;
 
        /* This is the scratch page we use to receive console input */
        port->inbuf = alloc_buf(PAGE_SIZE);