scsi: storvsc: properly handle SRB_ERROR when sense message is present
authorLong Li <longli@microsoft.com>
Thu, 15 Dec 2016 02:46:02 +0000 (18:46 -0800)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:17:02 +0000 (13:17 +0000)
commit bba5dc332ec2d3a685cb4dae668c793f6a3713a3 upstream.

When sense message is present on error, we should pass along to the upper
layer to decide how to deal with the error.
This patch fixes connectivity issues with Fiber Channel devices.

Signed-off-by: Long Li <longli@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/scsi/storvsc_drv.c

index 913b91c78a22ca04b04c6d84ec3f63a17745dfeb..2729023d111afb999590b8252e0c782e3fe173fc 100644 (file)
@@ -794,6 +794,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,
 
        switch (vm_srb->srb_status) {
        case SRB_STATUS_ERROR:
+               /*
+                * Let upper layer deal with error when
+                * sense message is present.
+                */
+
+               if (vm_srb->srb_status & SRB_STATUS_AUTOSENSE_VALID)
+                       break;
                /*
                 * If there is an error; offline the device since all
                 * error recovery strategies would have already been