staging: gdm72xx: use list_move instead of list_del/list_add
authorWei Yongjun <yongjun_wei@trendmicro.com.cn>
Thu, 6 Sep 2012 04:36:49 +0000 (12:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 6 Sep 2012 16:25:22 +0000 (09:25 -0700)
Using list_move() instead of list_del() + list_add().

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gdm72xx/gdm_usb.c

index 932a7974217eea93c999d03192b3116e780b7f1e..41e08a7c6855e2e236d9639833dec4474e307ea8 100644 (file)
@@ -186,8 +186,7 @@ static struct usb_rx *get_rx_struct(struct rx_cxt *rx)
 /* Before this function is called, spin lock should be locked. */
 static void put_rx_struct(struct rx_cxt *rx, struct usb_rx *r)
 {
-       list_del(&r->list);
-       list_add(&r->list, &rx->free_list);
+       list_move(&r->list, &rx->free_list);
 }
 
 static int init_usb(struct usbwm_dev *udev)