staging: lustre: uapi: remove CONFIG_LUSTRE_OBD_MAX_IOCTL
authorJames Simmons <jsimmons@infradead.org>
Sun, 20 Aug 2017 02:26:36 +0000 (22:26 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 23 Aug 2017 01:36:50 +0000 (18:36 -0700)
Now that lustre_ioctl.h is a UAPI header the kernel configuration
option CONFIG_LUSTRE_OBD_MAX_IOCTL needs to be remove. The user
land utilites will no longer be able to see this option and
actually they never used this option before. Since this is the
case setting the kernel configuration to something other than
8K could actually break things. The best option is just hard
code it to 8K.

Signed-off-by: James Simmons <uja.ornl@yahoo.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6401
Reviewed-on: https://review.whamcloud.com/25246
Reviewed-by: Quentin Bouget <quentin.bouget@cea.fr>
Reviewed-by: Ben Evans <bevans@cray.com>
Reviewed-by: Dmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/include/uapi/linux/lustre/lustre_ioctl.h
drivers/staging/lustre/lustre/Kconfig
drivers/staging/lustre/lustre/obdclass/linux/linux-module.c

index 3060e4dbbf774d02dbce9993ff7811a3e6bb6e3d..1f52477667f27f9d82b8e701120af49eaea7a7ae 100644 (file)
@@ -56,7 +56,6 @@ enum md_echo_cmd {
 
 #define OBD_IOCTL_VERSION      0x00010004
 #define OBD_DEV_BY_DEVNAME     0xffffd0de
-#define OBD_MAX_IOCTL_BUFFER   CONFIG_LUSTRE_OBD_MAX_IOCTL_BUFFER
 
 struct obd_ioctl_data {
        __u32           ioc_len;
index 9f5d75f166e7c9eda45a4a795b803c133e38e4b0..90d826946c6a554c6f481be79a9a7e72a08ba7e1 100644 (file)
@@ -31,16 +31,6 @@ config LUSTRE_FS
 
          See also http://wiki.lustre.org/
 
-config LUSTRE_OBD_MAX_IOCTL_BUFFER
-       int "Lustre obd max ioctl buffer bytes (default 8KB)"
-       depends on LUSTRE_FS
-       default 8192
-       help
-         This option defines the maximum size of buffer in bytes that user space
-         applications can pass to Lustre kernel module through ioctl interface.
-
-         If unsure, use default.
-
 config LUSTRE_DEBUG_EXPENSIVE_CHECK
        bool "Enable Lustre DEBUG checks"
        depends on LUSTRE_FS
index b2f55975bca7040e42800cd0eb817d3658aa7264..94af2574c683ae9d7e248df101cea557c7b7032c 100644 (file)
@@ -68,6 +68,8 @@
 #include "../../../include/uapi/linux/lustre/lustre_ioctl.h"
 #include "../../../include/uapi/linux/lustre/lustre_ver.h"
 
+#define OBD_MAX_IOCTL_BUFFER   8192
+
 static int obd_ioctl_is_invalid(struct obd_ioctl_data *data)
 {
        if (data->ioc_len > BIT(30)) {