powerpc/kernel: Remove error message in pcibios_setup_phb_resources()
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Wed, 8 Feb 2017 03:11:03 +0000 (14:11 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Fri, 17 Feb 2017 11:18:21 +0000 (22:18 +1100)
The CAPI driver creates virtual PHB (vPHB) from the CAPI adapter.
The vPHB's IO and memory windows aren't built from device-tree node
as we do for normal PHBs. A error message is thrown in below path
when trying to probe AFUs contained in the adapter. The error message
is confusing and unnecessary.

    cxl_probe()
    pci_init_afu()
    cxl_pci_vphb_add()
    pcibios_scan_phb()
    pcibios_setup_phb_resources()

This removes the error message. We might have the case where the
first memory window on real PHB isn't populated properly because
of error in "ranges" property in the device-tree node. We can check
the device-tree instead for that. This also removes one unnecessary
blank line in the function.

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/pci-common.c

index 74bec549897202e797b2f0c7de30ad7d83ed9cfb..05bfdaeaa2f9957f9d4593582920cdf0bbbfee59 100644 (file)
@@ -1559,16 +1559,10 @@ static void pcibios_setup_phb_resources(struct pci_controller *hose,
        /* Hookup PHB Memory resources */
        for (i = 0; i < 3; ++i) {
                res = &hose->mem_resources[i];
-               if (!res->flags) {
-                       if (i == 0)
-                               printk(KERN_ERR "PCI: Memory resource 0 not set for "
-                                      "host bridge %s (domain %d)\n",
-                                      hose->dn->full_name, hose->global_number);
+               if (!res->flags)
                        continue;
-               }
-               offset = hose->mem_offset[i];
-
 
+               offset = hose->mem_offset[i];
                pr_debug("PCI: PHB MEM resource %d = %pR off 0x%08llx\n", i,
                         res, (unsigned long long)offset);