xfs: small cleanup in xfs_lowbit64()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 6 Jun 2014 06:04:42 +0000 (16:04 +1000)
committerDave Chinner <david@fromorbit.com>
Fri, 6 Jun 2014 06:04:42 +0000 (16:04 +1000)
There are two checkpatch.pl complaints here because of the bad
indenting and because of the assignment inside the condition.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_bit.h

index f1e3c907044db190f9dccd1f6dce7453f9932495..e1649c0d3e02f0f4da1ce1f8476008d53c7a8a3f 100644 (file)
@@ -66,8 +66,11 @@ static inline int xfs_lowbit64(__uint64_t v)
                n = ffs(w);
        } else {        /* upper bits */
                w = (__uint32_t)(v >> 32);
-               if (w && (n = ffs(w)))
-               n += 32;
+               if (w) {
+                       n = ffs(w);
+                       if (n)
+                               n += 32;
+               }
        }
        return n - 1;
 }