[SCSI] fcoe: fixes wrong error exit in fcoe_create
authorVasu Dev <vasu.dev@intel.com>
Fri, 7 May 2010 22:18:19 +0000 (15:18 -0700)
committerJames Bottomley <James.Bottomley@suse.de>
Mon, 17 May 2010 02:22:27 +0000 (22:22 -0400)
fcoe_create exits using out_nodev label when module is not
yet LIVE but this exit path unlocks the rtnl_lock though
rtnl lock was not held in this case.

So this patch replaces out_nodev with out_nomod to exit
w/o unlocking rtnl_lock.

Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/fcoe/fcoe.c

index aba839e68014ac8f939b11b13e97bf9ed35f6733..7022a16b14f698c840e8ac2490598b0752f24b21 100644 (file)
@@ -2056,7 +2056,7 @@ static int fcoe_create(const char *buffer, struct kernel_param *kp)
         */
        if (THIS_MODULE->state != MODULE_STATE_LIVE) {
                rc = -ENODEV;
-               goto out_nodev;
+               goto out_nomod;
        }
 #endif