arch/sparc/mm: Use GFP_KERNEL
authorJulia Lawall <julia@diku.dk>
Mon, 2 Aug 2010 23:04:21 +0000 (16:04 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 2 Aug 2010 23:04:21 +0000 (16:04 -0700)
GFP_ATOMIC is not needed here, as evidenced by the other two uses of
GFP_KERNEL in the same function.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@ identifier f; @@

*f(...,GFP_ATOMIC,...)
... when != spin_unlock(...)
    when != read_unlock(...)
    when != write_unlock(...)
    when != read_unlock_irq(...)
    when != write_unlock_irq(...)
    when != read_unlock_irqrestore(...)
    when != write_unlock_irqrestore(...)
    when != spin_unlock_irq(...)
    when != spin_unlock_irqrestore(...)
*f(...,GFP_KERNEL,...)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/mm/iommu.c

index b2e6e73888b52e594e0f7de258c4de76a346d8bd..0e8ae298b3c3a7e8fedd26e93a6204915b887775 100644 (file)
@@ -63,7 +63,7 @@ static void __init sbus_iommu_init(struct of_device *op)
        unsigned long *bitmap;
        unsigned long tmp;
 
-       iommu = kmalloc(sizeof(struct iommu_struct), GFP_ATOMIC);
+       iommu = kmalloc(sizeof(struct iommu_struct), GFP_KERNEL);
        if (!iommu) {
                prom_printf("Unable to allocate iommu structure\n");
                prom_halt();