drm/i915: mdelay(10) considered harmful
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Fri, 11 Dec 2015 18:44:15 +0000 (19:44 +0100)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 17 Dec 2015 15:59:24 +0000 (16:59 +0100)
I missed this myself when reviewing

commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <sonika.jindal@intel.com>
Date:   Tue Sep 15 09:44:20 2015 +0530

    drm/i915: Check live status before reading edid

Long sleeps like this really shouldn't waste cpu cycles spinning.

Cc: Sonika Jindal <sonika.jindal@intel.com>
Cc: "Wang, Gary C" <gary.c.wang@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1449859455-32609-1-git-send-email-daniel.vetter@ffwll.ch
Reviewed-by: Sonika Jindal <sonika.jindal@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_hdmi.c

index 23f339e04f7353f5d06e5ddebf5d110a23639350..478e31fda067d3bfc7b6d38aa4a9e26ba7f9f04a 100644 (file)
@@ -1395,7 +1395,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
        while (!live_status && --retry) {
                live_status = intel_digital_port_connected(dev_priv,
                                hdmi_to_dig_port(intel_hdmi));
-               mdelay(10);
+               msleep(10);
        }
 
        if (!live_status)