media: ivtv: update *pos correctly in ivtv_read_pos()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 22 Feb 2019 06:36:41 +0000 (01:36 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:19 +0000 (10:24 +0100)
[ Upstream commit f8e579f3ca0973daef263f513da5edff520a6c0d ]

We had intended to update *pos, but the current code is a no-op.

Fixes: 1a0adaf37c30 ("V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/pci/ivtv/ivtv-fileops.c

index c9bd018e53de607f63cfe1367404be228ec90806..e2b19c3eaa87633e8109d2da8c9571e7d95ab4a8 100644 (file)
@@ -420,7 +420,7 @@ static ssize_t ivtv_read_pos(struct ivtv_stream *s, char __user *ubuf, size_t co
 
        IVTV_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc);
        if (rc > 0)
-               pos += rc;
+               *pos += rc;
        return rc;
 }