drm/nouveau: init vblank requests list

Fixes kernel panic when vblank interrupt triggers before first sync to
vblank request.

(Besides init, remove some relevant leftovers from vblank rework)

Reported-by: Ortwin Glück <odi@odi.ch>
Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: stable@vger.kernel.org [3.5]
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

diff --git a/drivers/gpu/drm/nouveau/nouveau_drv.h b/drivers/gpu/drm/nouveau/nouveau_drv.h
index 03da38373552b69809d101e8db34b77d756c69b0..4f2cc95ce26498e9df3fa389908ccd6e542b2a1d 100644 (file)
--- a/drivers/gpu/drm/nouveau/nouveau_drv.h
+++ b/drivers/gpu/drm/nouveau/nouveau_drv.h
@@ -689,8 +689,6 @@ struct drm_nouveau_private {
        void (*irq_handler[32])(struct drm_device *);
        bool msi_enabled;
 
-       struct list_head vbl_waiting;
-
        struct {
                struct drm_global_reference mem_global_ref;
                struct ttm_bo_global_ref bo_global_ref;

diff --git a/drivers/gpu/drm/nouveau/nouveau_irq.c b/drivers/gpu/drm/nouveau/nouveau_irq.c
index 868c7fd74854dae082581177858a48fe847b1ff1..b2c2937531a80e04854f287ca904369d346e148b 100644 (file)
--- a/drivers/gpu/drm/nouveau/nouveau_irq.c
+++ b/drivers/gpu/drm/nouveau/nouveau_irq.c
@@ -41,12 +41,8 @@
 void
 nouveau_irq_preinstall(struct drm_device *dev)
 {
-       struct drm_nouveau_private *dev_priv = dev->dev_private;
-
        /* Master disable */
        nv_wr32(dev, NV03_PMC_INTR_EN_0, 0);
-
-       INIT_LIST_HEAD(&dev_priv->vbl_waiting);
 }
 
 int

diff --git a/drivers/gpu/drm/nouveau/nouveau_software.h b/drivers/gpu/drm/nouveau/nouveau_software.h
index 9914cf154f6542ab4b9de14011c838b641e0eb82..709e5ac680ec8356ea5b5c4b4ba61bf5ae9c4480 100644 (file)
--- a/drivers/gpu/drm/nouveau/nouveau_software.h
+++ b/drivers/gpu/drm/nouveau/nouveau_software.h
@@ -23,6 +23,7 @@ static inline void
 nouveau_software_context_new(struct nouveau_software_chan *pch)
 {
        INIT_LIST_HEAD(&pch->flip);
+       INIT_LIST_HEAD(&pch->vblank.list);
 }
 
 static inline void