staging: fsl-mc: move comparison before strcmp() call
authorLaurentiu Tudor <laurentiu.tudor@nxp.com>
Tue, 27 Jun 2017 14:41:21 +0000 (17:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Jun 2017 14:38:52 +0000 (16:38 +0200)
Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.

Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-mc/bus/dprc-driver.c

index 80c080f20da154b5933790d554323c7af561d4ea..1765e2ddba11e8fca4747a7280688bc5b133e624 100644 (file)
@@ -29,8 +29,9 @@ struct dprc_child_objs {
 static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev,
                                struct dprc_obj_desc *obj_desc)
 {
-       return !strcmp(mc_dev->obj_desc.type, obj_desc->type) &&
-               mc_dev->obj_desc.id == obj_desc->id;
+       return mc_dev->obj_desc.id == obj_desc->id &&
+              !strcmp(mc_dev->obj_desc.type, obj_desc->type);
+
 }
 
 static int __fsl_mc_device_remove_if_not_in_mc(struct device *dev, void *data)