drm/i915: Check for id==PLANE_CURSOR instead of type==DRM_PLANE_TYPE_CURSOR
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 3 Mar 2017 15:19:26 +0000 (17:19 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 5 Apr 2017 10:22:37 +0000 (13:22 +0300)
The VLV/CHV watermark calculation is really interested in the hardware
plane type rather than the plane type (which is more of a software
concept). Let's check plane->id rather plane->type.

No functional changes.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170303151928.23053-3-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
drivers/gpu/drm/i915/intel_pm.c

index 570bd603f401d513ac3f08c67fc78d6d1523b762..2807054e49a5d6d2fec58f57bd7b08aba395093c 100644 (file)
@@ -1039,7 +1039,7 @@ static uint16_t vlv_compute_wm_level(const struct intel_crtc_state *crtc_state,
        if (WARN_ON(htotal == 0))
                htotal = 1;
 
-       if (plane->base.type == DRM_PLANE_TYPE_CURSOR) {
+       if (plane->id == PLANE_CURSOR) {
                /*
                 * FIXME the formula gives values that are
                 * too big for the cursor FIFO, and hence we