GFS2: Delete an unnecessary check before the function call "iput"
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 13 Nov 2015 13:55:59 +0000 (07:55 -0600)
committerBob Peterson <rpeterso@redhat.com>
Mon, 16 Nov 2015 17:56:26 +0000 (11:56 -0600)
The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Bob Peterson <rpeterso@redhat.com>
fs/gfs2/ops_fstype.c

index baab99b69d8ae3b56e7c74646d9c3783c1d3e3e7..1f9de173c4a0203e281dc172af0c9ca646851ac3 100644 (file)
@@ -910,8 +910,7 @@ fail_qc_i:
 fail_ut_i:
        iput(sdp->sd_sc_inode);
 fail:
-       if (pn)
-               iput(pn);
+       iput(pn);
        return error;
 }