usb: gadget: mv_u3d: fix sparse warnings
authorFelipe Balbi <balbi@ti.com>
Fri, 22 Mar 2013 15:01:42 +0000 (17:01 +0200)
committerFelipe Balbi <balbi@ti.com>
Wed, 27 Mar 2013 11:19:00 +0000 (13:19 +0200)
fix the following sparse warnings:

drivers/usb/gadget/mv_u3d_core.c:223:20: warning: context imbalance in 'mv_u3d_done' - unexpected unlock
drivers/usb/gadget/mv_u3d_core.c:1562:25: warning: context imbalance in 'mv_u3d_handle_setup_packet' - unexpected unlock

Note that the non-trivial sparse warnings
are left out of this commit due to lack of
HW to test:

drivers/usb/gadget/mv_u3d_core.c:906:42: warning: incorrect type in argument 2 (different address spaces)
drivers/usb/gadget/mv_u3d_core.c:906:42:    expected void [noderef] <asn:2>*<noident>
drivers/usb/gadget/mv_u3d_core.c:906:42:    got unsigned int *<noident>

Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/gadget/mv_u3d_core.c

index 5a6f87cf718aa97ce018cd1810509107e7bf5fe0..9675227a9529a4f14bbf9f591afd29e79035613c 100644 (file)
@@ -186,6 +186,8 @@ static int mv_u3d_process_ep_req(struct mv_u3d *u3d, int index,
  */
 static
 void mv_u3d_done(struct mv_u3d_ep *ep, struct mv_u3d_req *req, int status)
+       __releases(&ep->udc->lock)
+       __acquires(&ep->udc->lock)
 {
        struct mv_u3d *u3d = (struct mv_u3d *)ep->u3d;
 
@@ -1520,6 +1522,8 @@ static int mv_u3d_is_set_configuration(struct usb_ctrlrequest *setup)
 
 static void mv_u3d_handle_setup_packet(struct mv_u3d *u3d, u8 ep_num,
        struct usb_ctrlrequest *setup)
+       __releases(&u3c->lock)
+       __acquires(&u3c->lock)
 {
        bool delegate = false;