mfd: qcom-spmi-pmic: Use devm_of_platform_populate()
authorBenjamin Gaignard <benjamin.gaignard@linaro.org>
Mon, 29 May 2017 15:46:00 +0000 (17:46 +0200)
committerLee Jones <lee.jones@linaro.org>
Thu, 6 Jul 2017 07:29:12 +0000 (08:29 +0100)
Usage of  devm_of_platform_populate() simplify driver code
by allowing to delete pmic_spmi_remove().

Signed-off-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/qcom-spmi-pmic.c

index 8653e8b9bb4fc29359a1b84e7dd676f7cf4b2d9b..2022bdfa7ab4221a544f3222217678671712bca7 100644 (file)
@@ -120,7 +120,6 @@ static const struct regmap_config spmi_regmap_config = {
 
 static int pmic_spmi_probe(struct spmi_device *sdev)
 {
-       struct device_node *root = sdev->dev.of_node;
        struct regmap *regmap;
 
        regmap = devm_regmap_init_spmi_ext(sdev, &spmi_regmap_config);
@@ -131,19 +130,13 @@ static int pmic_spmi_probe(struct spmi_device *sdev)
        if (sdev->usid % 2 == 0)
                pmic_spmi_show_revid(regmap, &sdev->dev);
 
-       return of_platform_populate(root, NULL, NULL, &sdev->dev);
-}
-
-static void pmic_spmi_remove(struct spmi_device *sdev)
-{
-       of_platform_depopulate(&sdev->dev);
+       return devm_of_platform_populate(&sdev->dev);
 }
 
 MODULE_DEVICE_TABLE(of, pmic_spmi_id_table);
 
 static struct spmi_driver pmic_spmi_driver = {
        .probe = pmic_spmi_probe,
-       .remove = pmic_spmi_remove,
        .driver = {
                .name = "pmic-spmi",
                .of_match_table = pmic_spmi_id_table,