IB/ipath: Fix sparse warning about pointer signedness
authorArthur Jones <arthur.jones@qlogic.com>
Thu, 17 Apr 2008 04:01:06 +0000 (21:01 -0700)
committerRoland Dreier <rolandd@cisco.com>
Thu, 17 Apr 2008 04:01:06 +0000 (21:01 -0700)
There's no reason for the third parameter of ipath_count_units() to be
a u32 *, so change it to be an int * instead.  This fixes the sparse
warning:

    drivers/infiniband/hw/ipath/ipath_file_ops.c:1654:47: warning: incorrect type in argument 3 (different signedness)
    drivers/infiniband/hw/ipath/ipath_file_ops.c:1654:47:    expected unsigned int [usertype] *maxportsp
    drivers/infiniband/hw/ipath/ipath_file_ops.c:1654:47:    got int *<noident>

Signed-off-by: Arthur Jones <arthur.jones@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/hw/ipath/ipath_driver.c
drivers/infiniband/hw/ipath/ipath_kernel.h

index ca4d0acc6786768177126ca15af89407fbba235a..367f2a38744e45bb14254055e9c96f7ac4fb3993 100644 (file)
@@ -234,12 +234,12 @@ struct ipath_devdata *ipath_lookup(int unit)
        return dd;
 }
 
-int ipath_count_units(int *npresentp, int *nupp, u32 *maxportsp)
+int ipath_count_units(int *npresentp, int *nupp, int *maxportsp)
 {
        int nunits, npresent, nup;
        struct ipath_devdata *dd;
        unsigned long flags;
-       u32 maxports;
+       int maxports;
 
        nunits = npresent = nup = maxports = 0;
 
index ecf3f7ff77177837012af805c673b81b6b3a9bd9..3d4a254ffca03251bfdde8df91b813c49d51c3f5 100644 (file)
@@ -718,7 +718,7 @@ extern struct ipath_devdata *ipath_lookup(int unit);
 int ipath_init_chip(struct ipath_devdata *, int);
 int ipath_enable_wc(struct ipath_devdata *dd);
 void ipath_disable_wc(struct ipath_devdata *dd);
-int ipath_count_units(int *npresentp, int *nupp, u32 *maxportsp);
+int ipath_count_units(int *npresentp, int *nupp, int *maxportsp);
 void ipath_shutdown_device(struct ipath_devdata *);
 void ipath_clear_freeze(struct ipath_devdata *);