HID: hidraw: silence an uninitialized variable warning
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 2 Apr 2016 04:45:01 +0000 (07:45 +0300)
committerJiri Kosina <jkosina@suse.cz>
Mon, 4 Apr 2016 07:49:12 +0000 (09:49 +0200)
My static checker complains that "devid" can be uninitialized if
alloc_chrdev_region() fails.  Fix this by moving the error hanling
forward a couple lines.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hidraw.c

index 9c2d7c23f2966f43953626b82d03cf62bca0c8ba..4b981fd324e8d9c6c86bf3504aef922ee665e7ea 100644 (file)
@@ -587,14 +587,13 @@ int __init hidraw_init(void)
 
        result = alloc_chrdev_region(&dev_id, HIDRAW_FIRST_MINOR,
                        HIDRAW_MAX_DEVICES, "hidraw");
-
-       hidraw_major = MAJOR(dev_id);
-
        if (result < 0) {
                pr_warn("can't get major number\n");
                goto out;
        }
 
+       hidraw_major = MAJOR(dev_id);
+
        hidraw_class = class_create(THIS_MODULE, "hidraw");
        if (IS_ERR(hidraw_class)) {
                result = PTR_ERR(hidraw_class);