[media] drivers/media/rc/redrat3.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 4 Sep 2012 11:05:05 +0000 (08:05 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sun, 23 Sep 2012 16:40:14 +0000 (13:40 -0300)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/rc/redrat3.c

index 2878b0ed9741b27e497a171dab39e664f271cb27..49731b1a9c57f09a5e9aa43a199e7f5f4e5d766a 100644 (file)
@@ -1217,9 +1217,10 @@ static int __devinit redrat3_dev_probe(struct usb_interface *intf,
        rr3->carrier = 38000;
 
        rr3->rc = redrat3_init_rc_dev(rr3);
-       if (!rr3->rc)
+       if (!rr3->rc) {
+               retval = -ENOMEM;
                goto error;
-
+       }
        setup_timer(&rr3->rx_timeout, redrat3_rx_timeout, (unsigned long)rr3);
 
        /* we can register the device now, as it is ready */