drm/i915: show unknown sdvox registers on hdmi init
authorEugeni Dodonov <eugeni.dodonov@intel.com>
Wed, 9 May 2012 18:37:13 +0000 (15:37 -0300)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 19 May 2012 20:39:45 +0000 (22:39 +0200)
This will throw a BUG() message when an unknown sdvox register is
given to intel_hdmi_init. When this happens, things could going to be pretty
much broken afterwards, so we better detect this as soon as possible.

Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_hdmi.c

index 4a9d553719f6ed0c862714738685826ef61e2803..8da8dfe1b4fa47f0af7220530ea1e134accfa9a5 100644 (file)
@@ -661,6 +661,10 @@ void intel_hdmi_init(struct drm_device *dev, int sdvox_reg)
                intel_encoder->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
                intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
                dev_priv->hotplug_supported_mask |= HDMID_HOTPLUG_INT_STATUS;
+       } else {
+               /* If we got an unknown sdvox_reg, things are pretty much broken
+                * in a way that we should let the kernel know about it */
+               BUG();
        }
 
        intel_hdmi->sdvox_reg = sdvox_reg;