USB: Serial: omninet.c: remove debug module parameter
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2012 09:16:04 +0000 (10:16 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Sep 2012 09:16:04 +0000 (10:16 +0100)
Now that all usb-serial modules are only using dev_dbg()
the debug module parameter does not do anything at all, so
remove it to reduce any confusion if someone were to try to
use it.

CC: Johan Hovold <jhovold@gmail.com>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Alan Stern <stern@rowland.harvard.edu>
CC: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/omninet.c

index 7e81ed0c79ca9c9c26c2d2108afa73edba1a6759..4803b5ec19ba3107bbc9066c232873b5999f7c3b 100644 (file)
@@ -23,8 +23,6 @@
 #include <linux/usb.h>
 #include <linux/usb/serial.h>
 
-static bool debug;
-
 /*
  * Version Information
  */
@@ -172,17 +170,6 @@ static void omninet_read_bulk_callback(struct urb *urb)
                return;
        }
 
-       if (debug && header->oh_xxx != 0x30) {
-               if (urb->actual_length) {
-                       printk(KERN_DEBUG "%s: omninet_read %d: ",
-                              __FILE__, header->oh_len);
-                       for (i = 0; i < (header->oh_len +
-                                               OMNINET_HEADERLEN); i++)
-                               printk("%.2x ", data[i]);
-                       printk("\n");
-               }
-       }
-
        if (urb->actual_length && header->oh_len) {
                struct tty_struct *tty = tty_port_tty_get(&port->port);
                if (tty) {
@@ -306,6 +293,3 @@ module_usb_serial_driver(serial_drivers, id_table);
 MODULE_AUTHOR(DRIVER_AUTHOR);
 MODULE_DESCRIPTION(DRIVER_DESC);
 MODULE_LICENSE("GPL");
-
-module_param(debug, bool, S_IRUGO | S_IWUSR);
-MODULE_PARM_DESC(debug, "Debug enabled or not");