crypto: inside-secure - fix the cache_len computation
authorAntoine Tenart <antoine.tenart@bootlin.com>
Tue, 13 Feb 2018 08:26:53 +0000 (09:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 May 2018 14:17:45 +0000 (16:17 +0200)
[ Upstream commit 666a9c70b04fccabde5cea5e680ae1ae92460a62 ]

This patch fixes the cache length computation as cache_len could end up
being a negative value. The check between the queued size and the
block size is updated to reflect the caching mechanism which can cache
up to a full block size (included!).

Fixes: 809778e02cd4 ("crypto: inside-secure - fix hash when length is a multiple of a block")
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/crypto/inside-secure/safexcel_hash.c

index cd41c7623abaf0d73cea2736fb434a2f348a5001..861e31c476ba812dc544a92d5c6267880727ec0b 100644 (file)
@@ -185,7 +185,7 @@ static int safexcel_ahash_send_req(struct crypto_async_request *async, int ring,
        int i, queued, len, cache_len, extra, n_cdesc = 0, ret = 0;
 
        queued = len = req->len - req->processed;
-       if (queued < crypto_ahash_blocksize(ahash))
+       if (queued <= crypto_ahash_blocksize(ahash))
                cache_len = queued;
        else
                cache_len = queued - areq->nbytes;