userfaultfd: non-cooperative: Split the find_userfault() routine
authorPavel Emelyanov <xemul@parallels.com>
Wed, 22 Feb 2017 23:42:18 +0000 (15:42 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 23 Feb 2017 00:41:28 +0000 (16:41 -0800)
I will need one to lookup for userfaultfd_wait_queue-s in different
wait queue

Link: http://lkml.kernel.org/r/20161216144821.5183-6-aarcange@redhat.com
Signed-off-by: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
Signed-off-by: Andrea Arcangeli <aarcange@redhat.com>
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Hillf Danton <hillf.zj@alibaba-inc.com>
Cc: Michael Rapoport <RAPOPORT@il.ibm.com>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/userfaultfd.c

index 7e8f0d60718d882c696c87359a368205de19f16b..a209588043d3211a3772a8f765c8a87f3f3d6936 100644 (file)
@@ -522,25 +522,30 @@ wakeup:
 }
 
 /* fault_pending_wqh.lock must be hold by the caller */
-static inline struct userfaultfd_wait_queue *find_userfault(
-       struct userfaultfd_ctx *ctx)
+static inline struct userfaultfd_wait_queue *find_userfault_in(
+               wait_queue_head_t *wqh)
 {
        wait_queue_t *wq;
        struct userfaultfd_wait_queue *uwq;
 
-       VM_BUG_ON(!spin_is_locked(&ctx->fault_pending_wqh.lock));
+       VM_BUG_ON(!spin_is_locked(&wqh->lock));
 
        uwq = NULL;
-       if (!waitqueue_active(&ctx->fault_pending_wqh))
+       if (!waitqueue_active(wqh))
                goto out;
        /* walk in reverse to provide FIFO behavior to read userfaults */
-       wq = list_last_entry(&ctx->fault_pending_wqh.task_list,
-                            typeof(*wq), task_list);
+       wq = list_last_entry(&wqh->task_list, typeof(*wq), task_list);
        uwq = container_of(wq, struct userfaultfd_wait_queue, wq);
 out:
        return uwq;
 }
 
+static inline struct userfaultfd_wait_queue *find_userfault(
+               struct userfaultfd_ctx *ctx)
+{
+       return find_userfault_in(&ctx->fault_pending_wqh);
+}
+
 static unsigned int userfaultfd_poll(struct file *file, poll_table *wait)
 {
        struct userfaultfd_ctx *ctx = file->private_data;