drm/nouveau/bios: make jump conditional
authorIlia Mirkin <imirkin@alum.mit.edu>
Mon, 6 Jan 2014 01:07:02 +0000 (20:07 -0500)
committerBen Skeggs <bskeggs@redhat.com>
Tue, 7 Jan 2014 03:37:55 +0000 (13:37 +1000)
This fixes a hang in VBIOS scripts of the form "condition; jump".
The jump used to always be executed, while now it will only be
executed if the condition is true.

See https://bugs.freedesktop.org/show_bug.cgi?id=72943

Reported-by: Darcy BrĂ¡s da Silva <dardevelin@cidadecool.com>
Signed-off-by: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: stable@vger.kernel.org
drivers/gpu/drm/nouveau/core/subdev/bios/init.c

index 420908cb82b613bbc97fbccb9b123f3449926100..9f5b81e9973121bf5076b0e46f166b82876b6e6f 100644 (file)
@@ -1294,7 +1294,11 @@ init_jump(struct nvbios_init *init)
        u16 offset = nv_ro16(bios, init->offset + 1);
 
        trace("JUMP\t0x%04x\n", offset);
-       init->offset = offset;
+
+       if (init_exec(init))
+               init->offset = offset;
+       else
+               init->offset += 3;
 }
 
 /**