drm/i915: PSR HSW/BDW: Fix inverted logic at sink main_link_active bit.
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 12 Jan 2015 18:14:30 +0000 (10:14 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 15 Jan 2015 00:36:17 +0000 (01:36 +0100)
We have only two possible states with so many names and combinations that
might be confusing.

1 - Main link active / enabled / stand by / on
2 - Main link disabled / off / full off

Let's start organizing it by fixing a inverted logic when setting the sink bit.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Durgadoss R <durgadoss.r@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_psr.c

index 3dd88861f4170622068558f9b78ff1de4198f36a..0af89dbbe4c874ecc348b128ce849fc259e21110 100644 (file)
@@ -163,10 +163,10 @@ static void hsw_psr_enable_sink(struct intel_dp *intel_dp)
        /* Enable PSR in sink */
        if (intel_dp->psr_dpcd[1] & DP_PSR_NO_TRAIN_ON_EXIT || only_standby)
                drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG,
-                                  DP_PSR_ENABLE & ~DP_PSR_MAIN_LINK_ACTIVE);
+                                  DP_PSR_ENABLE DP_PSR_MAIN_LINK_ACTIVE);
        else
                drm_dp_dpcd_writeb(&intel_dp->aux, DP_PSR_EN_CFG,
-                                  DP_PSR_ENABLE DP_PSR_MAIN_LINK_ACTIVE);
+                                  DP_PSR_ENABLE & ~DP_PSR_MAIN_LINK_ACTIVE);
 
        /* Setup AUX registers */
        for (i = 0; i < sizeof(aux_msg); i += 4)