proc: use WARN() rather than printk+backtrace
authorArjan van de Ven <arjan@linux.intel.com>
Sun, 14 Sep 2008 02:51:30 +0000 (19:51 -0700)
committerAlexey Dobriyan <adobriyan@gmail.com>
Thu, 23 Oct 2008 09:34:38 +0000 (13:34 +0400)
Use WARN() rather than a printk() + backtrace();
this gives a more standard format message as well as complete
information (including line numbers etc) that will be collected
by kerneloops.org

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
fs/proc/generic.c

index 7821589a17d58748f9143108be13bbcd1de9dc97..60a359b355821a032c36d22beb4740fdc763075e 100644 (file)
@@ -547,9 +547,8 @@ static int proc_register(struct proc_dir_entry * dir, struct proc_dir_entry * dp
 
        for (tmp = dir->subdir; tmp; tmp = tmp->next)
                if (strcmp(tmp->name, dp->name) == 0) {
-                       printk(KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
+                       WARN(1, KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
                                dir->name, dp->name);
-                       dump_stack();
                        break;
                }