i2c: pxa: Add definition of fast and high speed modes via the regs layout
authorRomain Perier <romain.perier@free-electrons.com>
Thu, 1 Dec 2016 11:04:37 +0000 (12:04 +0100)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 1 Dec 2016 22:33:05 +0000 (23:33 +0100)
So far, the bit masks for the fast and high speed mode were statically
defined. Some IP blocks might use different bits for these modes.

This commit introduces new fields in order to enable the definition of
different bit masks for these features. If these fields are undefined,
ICR_FM and ICR_HS are selected to preserve backward compatibility with
other IPs.

Signed-off-by: Romain Perier <romain.perier@free-electrons.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-pxa.c

index e28b825b0433783799319db31e8471320dd7fb82..b4ac235c48ff9ae27a52e5dc2800066c2f39b0a6 100644 (file)
@@ -48,6 +48,8 @@ struct pxa_reg_layout {
        u32 isar;
        u32 ilcr;
        u32 iwcr;
+       u32 fm;
+       u32 hs;
 };
 
 enum pxa_i2c_types {
@@ -193,6 +195,8 @@ struct pxa_i2c {
        unsigned char           master_code;
        unsigned long           rate;
        bool                    highmode_enter;
+       u32                     fm_mask;
+       u32                     hs_mask;
 };
 
 #define _IBMR(i2c)     ((i2c)->reg_ibmr)
@@ -503,8 +507,8 @@ static void i2c_pxa_reset(struct pxa_i2c *i2c)
                writel(i2c->slave_addr, _ISAR(i2c));
 
        /* set control register values */
-       writel(I2C_ICR_INIT | (i2c->fast_mode ? ICR_FM : 0), _ICR(i2c));
-       writel(readl(_ICR(i2c)) | (i2c->high_mode ? ICR_HS : 0), _ICR(i2c));
+       writel(I2C_ICR_INIT | (i2c->fast_mode ? i2c->fm_mask : 0), _ICR(i2c));
+       writel(readl(_ICR(i2c)) | (i2c->high_mode ? i2c->hs_mask : 0), _ICR(i2c));
 
 #ifdef CONFIG_I2C_PXA_SLAVE
        dev_info(&i2c->adap.dev, "Enabling slave mode\n");
@@ -1234,6 +1238,9 @@ static int i2c_pxa_probe(struct platform_device *dev)
        i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr;
        i2c->reg_icr = i2c->reg_base + pxa_reg_layout[i2c_type].icr;
        i2c->reg_isr = i2c->reg_base + pxa_reg_layout[i2c_type].isr;
+       i2c->fm_mask = pxa_reg_layout[i2c_type].fm ? : ICR_FM;
+       i2c->hs_mask = pxa_reg_layout[i2c_type].hs ? : ICR_HS;
+
        if (i2c_type != REGS_CE4100)
                i2c->reg_isar = i2c->reg_base + pxa_reg_layout[i2c_type].isar;