projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: c2e3f5d)
[s390] remove pointless assignment of ->f_op in vmlogrdr ->open()
authorAl Viro <viro@zeniv.linux.org.uk>
Tue, 2 Sep 2014 23:42:14 +0000 (19:42 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Thu, 9 Oct 2014 06:39:13 +0000 (02:39 -0400)
The only way we can get to that function is from misc_open(), after
the latter has set file->f_op to exactly the same value we are
(re)assigning there.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
drivers/s390/char/vmlogrdr.c patch | blob | blame | history

diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char/vmlogrdr.c
index a8848db7b09dd25f5d7dadb6a743dcb28f0262b0..9bb48d70957cb254d6858e08d3db09c796df6c98 100644 (file)
--- a/drivers/s390/char/vmlogrdr.c
+++ b/drivers/s390/char/vmlogrdr.c
@@ -338,7 +338,6 @@ static int vmlogrdr_open (struct inode *inode, struct file *filp)
 
        /* set the file options */
        filp->private_data = logptr;
-       filp->f_op = &vmlogrdr_fops;
 
        /* start recording for this service*/
        if (logptr->autorecording) {