drm/i915: Warn if irq_mask isn't ~0 during vlv/cvh display irq postinstall
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Mon, 11 Apr 2016 13:56:29 +0000 (16:56 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 12 Apr 2016 16:08:51 +0000 (19:08 +0300)
We expect vlv_display_irq_reset() to have been called prior to
vlv_display_irq_postinstall() so let's WARN if that isn't the case.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1460382992-28728-8-git-send-email-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/i915_irq.c

index 34ad999b8300962ea1e513757c2254ab532876d6..df3751323511c1fe8b4ffbfab9c1eacbf8f7b128 100644 (file)
@@ -3321,6 +3321,9 @@ static void vlv_display_irq_postinstall(struct drm_i915_private *dev_priv)
                I915_DISPLAY_PIPE_B_EVENT_INTERRUPT;
        if (IS_CHERRYVIEW(dev_priv))
                enable_mask |= I915_DISPLAY_PIPE_C_EVENT_INTERRUPT;
+
+       WARN_ON(dev_priv->irq_mask != ~0);
+
        dev_priv->irq_mask = ~enable_mask;
 
        GEN5_IRQ_INIT(VLV_, dev_priv->irq_mask, enable_mask);