USB: ch341: replace printk warnings with dev_err
authorJohan Hovold <jhovold@gmail.com>
Mon, 28 Dec 2009 22:01:45 +0000 (23:01 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 2 Mar 2010 22:53:49 +0000 (14:53 -0800)
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/ch341.c

index 59eff721fcc5bb1e3374b1bfd098b0a67b558ddc..5e455f4a792ebabde05690268d593045fa5f9531 100644 (file)
@@ -399,8 +399,8 @@ static void ch341_break_ctl(struct tty_struct *tty, int break_state)
        r = ch341_control_in(port->serial->dev, CH341_REQ_READ_REG,
                        ch341_break_reg, 0, break_reg, sizeof(break_reg));
        if (r < 0) {
-               printk(KERN_WARNING "%s: USB control read error whilst getting"
-                               " break register contents.\n", __FILE__);
+               dev_err(&port->dev, "%s - USB control read error (%d)\n",
+                               __func__, r);
                return;
        }
        dbg("%s - initial ch341 break register contents - reg1: %x, reg2: %x",
@@ -420,8 +420,8 @@ static void ch341_break_ctl(struct tty_struct *tty, int break_state)
        r = ch341_control_out(port->serial->dev, CH341_REQ_WRITE_REG,
                        ch341_break_reg, reg_contents);
        if (r < 0)
-               printk(KERN_WARNING "%s: USB control write error whilst setting"
-                               " break register contents.\n", __FILE__);
+               dev_err(&port->dev, "%s - USB control write error (%d)\n",
+                               __func__, r);
 }
 
 static int ch341_tiocmset(struct tty_struct *tty, struct file *file,