tty: serial: msm: Fix style warnings relating to printk()
authorKiran Padwal <kiran.padwal@smartplayin.com>
Tue, 5 Aug 2014 07:52:01 +0000 (13:22 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 8 Sep 2014 22:28:28 +0000 (15:28 -0700)
fixed below checkpatch.pl warning:

WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...

Signed-off-by: Kiran Padwal <kiran.padwal@smartplayin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/msm_serial.c

index 0295493976d91c518224990d95d1ee9a08bf42f1..e70d4e80d4a88fcb73d36c749484fb013120ba32 100644 (file)
@@ -677,7 +677,7 @@ static void msm_power(struct uart_port *port, unsigned int state,
                clk_disable_unprepare(msm_port->pclk);
                break;
        default:
-               printk(KERN_ERR "msm_serial: Unknown PM state %d\n", state);
+               pr_err("msm_serial: Unknown PM state %d\n", state);
        }
 }
 
@@ -957,7 +957,7 @@ static int __init msm_console_setup(struct console *co, char *options)
                msm_write(port, UART_CR_TX_ENABLE, UART_CR);
        }
 
-       printk(KERN_INFO "msm_serial: console setup on port #%d\n", port->line);
+       pr_info("msm_serial: console setup on port #%d\n", port->line);
 
        return uart_set_options(port, co, baud, parity, bits, flow);
 }
@@ -1012,7 +1012,7 @@ static int msm_serial_probe(struct platform_device *pdev)
        if (unlikely(pdev->id < 0 || pdev->id >= UART_NR))
                return -ENXIO;
 
-       printk(KERN_INFO "msm_serial: detected port #%d\n", pdev->id);
+       dev_info(&pdev->dev, "msm_serial: detected port #%d\n", pdev->id);
 
        port = get_port_from_line(pdev->id);
        port->dev = &pdev->dev;
@@ -1037,8 +1037,7 @@ static int msm_serial_probe(struct platform_device *pdev)
        }
 
        port->uartclk = clk_get_rate(msm_port->clk);
-       printk(KERN_INFO "uartclk = %d\n", port->uartclk);
-
+       dev_info(&pdev->dev, "uartclk = %d\n", port->uartclk);
 
        resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        if (unlikely(!resource))
@@ -1092,7 +1091,7 @@ static int __init msm_serial_init(void)
        if (unlikely(ret))
                uart_unregister_driver(&msm_uart_driver);
 
-       printk(KERN_INFO "msm_serial: driver initialized\n");
+       pr_info("msm_serial: driver initialized\n");
 
        return ret;
 }