Revert "drm/i915: reenable gmbus on gen3+ again"
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 9 Apr 2012 19:10:38 +0000 (21:10 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 11 Apr 2012 10:11:23 +0000 (12:11 +0200)
This reverts commit c3dfefa0a6d235bd465309e12f4c56ea16e71111.

gmbus in 3.4 has simply too many known issues:
- gmbus is too noisy, we need to rework the logging:
  https://bugs.freedesktop.org/show_bug.cgi?id=48248
- zero-length writes cause an OOPS, and they are
  userspace-triggerable:
  https://lkml.org/lkml/2012/3/30/176
- same for zero-length reads:
  https://bugs.freedesktop.org/show_bug.cgi?id=48269

We can try again for 3.5.

Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-Off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_i2c.c

index 601c86e664afd237875aefc43fe65a0671930cb5..8fdc9570021853e3c94fec296a7bca3e14a60b7b 100644 (file)
@@ -390,7 +390,7 @@ int intel_setup_gmbus(struct drm_device *dev)
                bus->has_gpio = intel_gpio_setup(bus, i);
 
                /* XXX force bit banging until GMBUS is fully debugged */
-               if (bus->has_gpio && IS_GEN2(dev))
+               if (bus->has_gpio)
                        bus->force_bit = true;
        }