drivers/video/sunxvr1000.c: fix error return code
authorPeter Senna Tschudin <peter.senna@gmail.com>
Tue, 18 Sep 2012 12:07:52 +0000 (14:07 +0200)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Sat, 22 Sep 2012 21:41:51 +0000 (21:41 +0000)
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/sunxvr1000.c

index b7f27acaf817075e0ccde9e8108e296c2184f792..729a50722bdfb05138983fbf50c0e74145a97f6d 100644 (file)
@@ -141,8 +141,10 @@ static int __devinit gfb_probe(struct platform_device *op)
 
        gp->fb_base = of_ioremap(&op->resource[6], 0,
                                 gp->fb_size, "gfb fb");
-       if (!gp->fb_base)
+       if (!gp->fb_base) {
+               err = -ENOMEM;
                goto err_release_fb;
+       }
 
        err = gfb_set_fbinfo(gp);
        if (err)