dma-buf/fence: revert "don't wait when specified timeout is zero" (v2)
authorAlex Deucher <alexdeucher@gmail.com>
Mon, 7 Nov 2016 21:16:14 +0000 (16:16 -0500)
committerSumit Semwal <sumit.semwal@linaro.org>
Tue, 8 Nov 2016 19:15:33 +0000 (00:45 +0530)
Reverts commit 847b19a39e4c
("dma-buf/fence: don't wait when specified timeout is zero")

When we don't call the wait function software signaling might never be
activated. This can cause infinite polling loops with unreliable interrupt
driven hardware.

v2: rebase on drm-next

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
  [sumits: reword commit msg for checkpatch warnings]
Link: http://patchwork.freedesktop.org/patch/msgid/1478553376-18575-2-git-send-email-alexander.deucher@amd.com
drivers/dma-buf/dma-fence.c

index 70f4fcc0bc03fa6c460f113cb4e37e00fe53ef94..0212af7997d9fa2177b39d05b675ad047743f35f 100644 (file)
@@ -161,9 +161,6 @@ dma_fence_wait_timeout(struct dma_fence *fence, bool intr, signed long timeout)
        if (WARN_ON(timeout < 0))
                return -EINVAL;
 
-       if (timeout == 0)
-               return dma_fence_is_signaled(fence);
-
        trace_dma_fence_wait_start(fence);
        ret = fence->ops->wait(fence, intr, timeout);
        trace_dma_fence_wait_end(fence);