net/3com: Make el3_netdev_get_ecmd return void
authoryuval.shaia@oracle.com <yuval.shaia@oracle.com>
Sun, 4 Jun 2017 17:24:46 +0000 (20:24 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Jun 2017 15:00:43 +0000 (11:00 -0400)
Make return value void since function never returns meaningfull value.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/3com/3c509.c

index db8592d412abc5268ed95629666636daa496e87f..f66c9710cb81f87a59696247c65ef1637ff4b2c8 100644 (file)
@@ -1039,7 +1039,7 @@ el3_link_ok(struct net_device *dev)
        return tmp & (1<<11);
 }
 
-static int
+static void
 el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
 {
        u16 tmp;
@@ -1082,7 +1082,6 @@ el3_netdev_get_ecmd(struct net_device *dev, struct ethtool_link_ksettings *cmd)
                                                supported);
        cmd->base.speed = SPEED_10;
        EL3WINDOW(1);
-       return 0;
 }
 
 static int
@@ -1151,12 +1150,11 @@ static int el3_get_link_ksettings(struct net_device *dev,
                                  struct ethtool_link_ksettings *cmd)
 {
        struct el3_private *lp = netdev_priv(dev);
-       int ret;
 
        spin_lock_irq(&lp->lock);
-       ret = el3_netdev_get_ecmd(dev, cmd);
+       el3_netdev_get_ecmd(dev, cmd);
        spin_unlock_irq(&lp->lock);
-       return ret;
+       return 0;
 }
 
 static int el3_set_link_ksettings(struct net_device *dev,