usb: dwc3: drop ev_buffs array
authorFelipe Balbi <felipe.balbi@linux.intel.com>
Wed, 30 Mar 2016 06:37:03 +0000 (09:37 +0300)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Thu, 14 Apr 2016 06:24:39 +0000 (09:24 +0300)
we will be using a single event buffer and that
renders ev_buffs array unnecessary. Let's remove it
in favor of a single pointer to a single event
buffer.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/core.c
drivers/usb/dwc3/core.h
drivers/usb/dwc3/gadget.c

index 9e5c57c7943d208e862bfbf1dfee695e93721e98..05b7ec30266fc6e4e3c107f094470192f9399949 100644 (file)
@@ -204,7 +204,7 @@ static void dwc3_free_event_buffers(struct dwc3 *dwc)
 {
        struct dwc3_event_buffer        *evt;
 
-       evt = dwc->ev_buffs[0];
+       evt = dwc->ev_buf;
        if (evt)
                dwc3_free_one_event_buffer(dwc, evt);
 }
@@ -221,17 +221,12 @@ static int dwc3_alloc_event_buffers(struct dwc3 *dwc, unsigned length)
 {
        struct dwc3_event_buffer *evt;
 
-       dwc->ev_buffs = devm_kzalloc(dwc->dev, sizeof(*dwc->ev_buffs),
-                       GFP_KERNEL);
-       if (!dwc->ev_buffs)
-               return -ENOMEM;
-
        evt = dwc3_alloc_one_event_buffer(dwc, length);
        if (IS_ERR(evt)) {
                dev_err(dwc->dev, "can't allocate event buffer\n");
                return PTR_ERR(evt);
        }
-       dwc->ev_buffs[0] = evt;
+       dwc->ev_buf = evt;
 
        return 0;
 }
@@ -246,7 +241,7 @@ static int dwc3_event_buffers_setup(struct dwc3 *dwc)
 {
        struct dwc3_event_buffer        *evt;
 
-       evt = dwc->ev_buffs[0];
+       evt = dwc->ev_buf;
        dwc3_trace(trace_dwc3_core,
                        "Event buf %p dma %08llx length %d\n",
                        evt->buf, (unsigned long long) evt->dma,
@@ -269,7 +264,7 @@ static void dwc3_event_buffers_cleanup(struct dwc3 *dwc)
 {
        struct dwc3_event_buffer        *evt;
 
-       evt = dwc->ev_buffs[0];
+       evt = dwc->ev_buf;
 
        evt->lpos = 0;
 
index be03999e2dfd505cb087081cf4021193421dcc98..df72234a805b8ce4091696efadcbf4241939f0f1 100644 (file)
@@ -753,7 +753,7 @@ struct dwc3 {
        struct platform_device  *xhci;
        struct resource         xhci_resources[DWC3_XHCI_RESOURCES_NUM];
 
-       struct dwc3_event_buffer **ev_buffs;
+       struct dwc3_event_buffer *ev_buf;
        struct dwc3_ep          *eps[DWC3_ENDPOINTS_NUM];
 
        struct usb_gadget       gadget;
index 5e6a4956655d00b0006e52fd7b23d0a552b8fa33..96dfde011c76d5de06ed029cf11600a7a4e3bea9 100644 (file)
@@ -2609,7 +2609,7 @@ static irqreturn_t dwc3_process_event_buf(struct dwc3 *dwc)
        int left;
        u32 reg;
 
-       evt = dwc->ev_buffs[0];
+       evt = dwc->ev_buf;
        left = evt->count;
 
        if (!(evt->flags & DWC3_EVENT_PENDING))
@@ -2668,7 +2668,7 @@ static irqreturn_t dwc3_check_event_buf(struct dwc3 *dwc)
        u32 count;
        u32 reg;
 
-       evt = dwc->ev_buffs[0];
+       evt = dwc->ev_buf;
 
        count = dwc3_readl(dwc->regs, DWC3_GEVNTCOUNT(0));
        count &= DWC3_GEVNTCOUNT_MASK;