USB: serial/kobil_sct, fix potential tty NULL dereference
authorJiri Slaby <jslaby@suse.cz>
Mon, 28 Feb 2011 09:34:06 +0000 (10:34 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 1 Mar 2011 03:24:54 +0000 (19:24 -0800)
Make sure that we check the return value of tty_port_tty_get.
Sometimes it may return NULL and we later dereference that.

The only place here is in kobil_read_int_callback, so fix it.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/kobil_sct.c

index bd5bd8589e04cc300f43674079afa3f54715ee35..b382d9a0274d553545dc2e5cb3ed53d7e67ceb54 100644 (file)
@@ -372,7 +372,7 @@ static void kobil_read_int_callback(struct urb *urb)
        }
 
        tty = tty_port_tty_get(&port->port);
-       if (urb->actual_length) {
+       if (tty && urb->actual_length) {
 
                /* BEGIN DEBUG */
                /*