staging: sbe-2t3e3: remove t3e3_rx_desc_t typedef
authorKristina Martšenko <kristina.martsenko@gmail.com>
Mon, 3 Mar 2014 21:05:42 +0000 (23:05 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 7 Mar 2014 21:32:47 +0000 (13:32 -0800)
Kernel coding style does not recommend using typedefs for structures, so
remove the t3e3_rx_desc_t typedef.

Fix the following checkpatch warning:
drivers/staging/sbe-2t3e3/2t3e3.h:616: WARNING: do not add new typedefs

Signed-off-by: Kristina Martšenko <kristina.martsenko@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sbe-2t3e3/2t3e3.h
drivers/staging/sbe-2t3e3/dc.c
drivers/staging/sbe-2t3e3/intr.c

index a799975efd3f4f6fa9b4d08a3e2b5f66626717e7..3577fad61c5e88d03c06d8460e48cb8b36f2f5bb 100644 (file)
  * descriptor list and data buffer
  *
  **********************************************************************/
-typedef struct {
+struct t3e3_rx_desc {
        u32 rdes0;
        u32 rdes1;
        u32 rdes2;
        u32 rdes3;
-} t3e3_rx_desc_t;
+};
 
 #define SBE_2T3E3_RX_DESC_RING_SIZE                    64
 
@@ -723,7 +723,7 @@ struct channel {
                u32 interrupt_enable_mask;
 
                /* receive chain/ring */
-               t3e3_rx_desc_t *rx_ring;
+               struct t3e3_rx_desc *rx_ring;
                struct sk_buff *rx_data[SBE_2T3E3_RX_DESC_RING_SIZE];
                u32 rx_ring_current_read;
 
index 42ae67c5bc3352200c299b183d51c421c88c5539..0d60bc77f91a94fa93a9abc5f891b66c357b1c29 100644 (file)
@@ -316,7 +316,7 @@ static int dc_init_descriptor_list(struct channel *sc)
 
        if (sc->ether.rx_ring == NULL)
                sc->ether.rx_ring = kcalloc(SBE_2T3E3_RX_DESC_RING_SIZE,
-                                           sizeof(t3e3_rx_desc_t), GFP_KERNEL);
+                                           sizeof(struct t3e3_rx_desc), GFP_KERNEL);
        if (sc->ether.rx_ring == NULL)
                return -ENOMEM;
 
index efdeb751004798f7c5887c0999f73e5ab8a6553d..a346c516bcc32bb6ce59879ad9acf9f6f966445b 100644 (file)
@@ -118,7 +118,7 @@ void dc_intr_rx(struct channel *sc)
 {
        u32 current_read;
        u32 error_mask, error;
-       t3e3_rx_desc_t *current_desc;
+       struct t3e3_rx_desc *current_desc;
        struct sk_buff *m, *m2;
        unsigned rcv_len;