sky2: Hold RTNL while calling dev_close()
authorBen Hutchings <bhutchings@solarflare.com>
Sat, 31 May 2008 15:52:52 +0000 (16:52 +0100)
committerJeff Garzik <jgarzik@redhat.com>
Tue, 10 Jun 2008 22:40:44 +0000 (18:40 -0400)
dev_close() must be called holding the RTNL.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/sky2.c

index 3bb60530d4d78528f2a93a349db764334c736bcc..62436b3a18c6fdf1a4ef55a44fb3ee6d22a48633 100644 (file)
@@ -4404,7 +4404,9 @@ static int sky2_resume(struct pci_dev *pdev)
                        if (err) {
                                printk(KERN_ERR PFX "%s: could not up: %d\n",
                                       dev->name, err);
+                               rtnl_lock();
                                dev_close(dev);
+                               rtnl_unlock();
                                goto out;
                        }
                }