netxen: The driver doesn't work on NX_P3_B1 so cause probe to fail.
authorEric W. Biederman <ebiederm@xmission.com>
Wed, 17 Mar 2010 22:24:39 +0000 (22:24 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 23 Mar 2010 03:32:38 +0000 (20:32 -0700)
I haven't been able to get link up on a NX_P3_B1 since 2.6.31.  The
driver complains about a firmware hang instead.  When I asked I was
told rev 0x41 was a preproduction rev.  So disable support in the
driver so no one is surprised the code doesn't work.

Signed-off-by: Eric W. Biederman <ebiederm@aristanetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/netxen/netxen_nic_main.c

index 08780ef1c1f885d56b38d9c4ff68b4f790711f58..9a7a0f3c36c4b759aa90e8001650362ebea08529 100644 (file)
@@ -1246,8 +1246,8 @@ netxen_nic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
        int pci_func_id = PCI_FUNC(pdev->devfn);
        uint8_t revision_id;
 
-       if (pdev->revision >= NX_P3_A0 && pdev->revision < NX_P3_B1) {
-               pr_warning("%s: chip revisions between 0x%x-0x%x"
+       if (pdev->revision >= NX_P3_A0 && pdev->revision <= NX_P3_B1) {
+               pr_warning("%s: chip revisions between 0x%x-0x%x "
                                "will not be enabled.\n",
                                module_name(THIS_MODULE), NX_P3_A0, NX_P3_B1);
                return -ENODEV;