leds: gpio: introduce gpio_blink_set_t

Introduce a typedef gpio_blink_set_t to improve readability of the code.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>

diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 9b991d46ed848a0de40185eef30d9691c7e07e88..3599b2e4977c76599bc4def89959e43eb101194d 100644 (file)
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -26,8 +26,7 @@ struct gpio_led_data {
        struct gpio_desc *gpiod;
        u8 can_sleep;
        u8 blinking;
-       int (*platform_gpio_blink_set)(struct gpio_desc *desc, int state,
-                       unsigned long *delay_on, unsigned long *delay_off);
+       gpio_blink_set_t platform_gpio_blink_set;
 };
 
 static void gpio_led_set(struct led_classdev *led_cdev,
@@ -74,8 +73,7 @@ static int gpio_blink_set(struct led_classdev *led_cdev,
 
 static int create_gpio_led(const struct gpio_led *template,
        struct gpio_led_data *led_dat, struct device *parent,
-       int (*blink_set)(struct gpio_desc *, int, unsigned long *,
-                        unsigned long *))
+       gpio_blink_set_t blink_set)
 {
        int ret, state;
 

diff --git a/include/linux/leds.h b/include/linux/leds.h
index 8a3b5d29602ffe665cfb26522180f3a696664371..ddfcb2df3656cf0ab6aebd1fa3d624a6ec2e94e9 100644 (file)
--- a/include/linux/leds.h
+++ b/include/linux/leds.h
@@ -359,6 +359,11 @@ struct led_platform_data {
        struct led_info *leds;
 };
 
+struct gpio_desc;
+typedef int (*gpio_blink_set_t)(struct gpio_desc *desc, int state,
+                               unsigned long *delay_on,
+                               unsigned long *delay_off);
+
 /* For the leds-gpio driver */
 struct gpio_led {
        const char *name;
@@ -382,9 +387,7 @@ struct gpio_led_platform_data {
 #define GPIO_LED_NO_BLINK_LOW  0       /* No blink GPIO state low */
 #define GPIO_LED_NO_BLINK_HIGH 1       /* No blink GPIO state high */
 #define GPIO_LED_BLINK         2       /* Please, blink */
-       int             (*gpio_blink_set)(struct gpio_desc *desc, int state,
-                                       unsigned long *delay_on,
-                                       unsigned long *delay_off);
+       gpio_blink_set_t        gpio_blink_set;
 };
 
 #ifdef CONFIG_NEW_LEDS