net: dsa: mv88e6xxx: use setup_timer to simplify the code
authorWei Yongjun <weiyongjun1@huawei.com>
Sat, 22 Oct 2016 14:28:00 +0000 (14:28 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Oct 2016 21:21:59 +0000 (17:21 -0400)
Use setup_timer function instead of initializing timer with the function
and data fields.

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index 157360f250695bd083148969e8c08bbed23b9dd8..72b9dac29901b7772ff87795a44dcdb724ecd268 100644 (file)
@@ -639,9 +639,8 @@ static void mv88e6xxx_ppu_state_init(struct mv88e6xxx_chip *chip)
 {
        mutex_init(&chip->ppu_mutex);
        INIT_WORK(&chip->ppu_work, mv88e6xxx_ppu_reenable_work);
-       init_timer(&chip->ppu_timer);
-       chip->ppu_timer.data = (unsigned long)chip;
-       chip->ppu_timer.function = mv88e6xxx_ppu_reenable_timer;
+       setup_timer(&chip->ppu_timer, mv88e6xxx_ppu_reenable_timer,
+                   (unsigned long)chip);
 }
 
 static void mv88e6xxx_ppu_state_destroy(struct mv88e6xxx_chip *chip)