mn10300/PCI: Add struct pci_ops member names to initialization
authorRob Herring <robh@kernel.org>
Sat, 10 Jan 2015 02:34:37 +0000 (20:34 -0600)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 22 Jan 2015 19:57:49 +0000 (13:57 -0600)
Some instances of pci_ops initialization rely on the read/write members'
location in the struct.  This is fragile and may break when adding new
members to the beginning of the struct.

No functional change.

Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: David Howells <dhowells@redhat.com>
CC: Koichi Yasutake <yasutake.koichi@jp.panasonic.com>
CC: linux-am33-list@redhat.com
arch/mn10300/unit-asb2305/pci.c

index 6b4339f8c9c2e1e757f13fddccb9053c2c292b0c..406cbe048471ff37b06b27825a38e224bf4883b3 100644 (file)
@@ -228,8 +228,8 @@ static int pci_ampci_write_config(struct pci_bus *bus, unsigned int devfn,
 }
 
 static struct pci_ops pci_direct_ampci = {
-       pci_ampci_read_config,
-       pci_ampci_write_config,
+       .read = pci_ampci_read_config,
+       .write = pci_ampci_write_config,
 };
 
 /*