Staging: iio/light: Fix return values in tsl2583.c

This patch fixes following smatch warnings:
/drivers/staging/iio/light/tsl2583.c:436 taos_chip_on() info: why not propagate 'ret' from i2c_smbus_write_byte_data() instead of (-1)?
/drivers/staging/iio/light/tsl2583.c:448 taos_chip_on() info: why not propagate 'ret' from i2c_smbus_write_byte_data() instead of (-1)?
/drivers/staging/iio/light/tsl2583.c:461 taos_chip_on() info: why not propagate 'ret' from i2c_smbus_write_byte_data() instead of (-1)?

Signed-off-by: Monam Agarwal <monamagarwal123@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
index f8c659568c384f1884e74757df2981deb508b0ab..0a60def92735e16566185d7d6eee8c30f4b7395d 100644 (file)
--- a/drivers/staging/iio/light/tsl2583.c
+++ b/drivers/staging/iio/light/tsl2583.c
@@ -433,7 +433,7 @@ static int taos_chip_on(struct iio_dev *indio_dev)
                                        TSL258X_CMD_REG | TSL258X_CNTRL, utmp);
        if (ret < 0) {
                dev_err(&chip->client->dev, "taos_chip_on failed on CNTRL reg.\n");
-               return -1;
+               return ret;
        }
 
        /* Use the following shadow copy for our delay before enabling ADC.
@@ -445,7 +445,7 @@ static int taos_chip_on(struct iio_dev *indio_dev)
                if (ret < 0) {
                        dev_err(&chip->client->dev,
                                "taos_chip_on failed on reg %d.\n", i);
-                       return -1;
+                       return ret;
                }
        }
 
@@ -458,7 +458,7 @@ static int taos_chip_on(struct iio_dev *indio_dev)
                                        utmp);
        if (ret < 0) {
                dev_err(&chip->client->dev, "taos_chip_on failed on 2nd CTRL reg.\n");
-               return -1;
+               return ret;
        }
        chip->taos_chip_status = TSL258X_CHIP_WORKING;