PCI: pciehp: ignore undefined bit in link status register
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Fri, 19 Dec 2008 06:18:10 +0000 (15:18 +0900)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Wed, 7 Jan 2009 19:13:21 +0000 (11:13 -0800)
Bit 10 in Link Status register used to be defined as Training Error in
the PCI Express 1.0a specification. But it was removed by Training Error
ECN and is no longer defined. So pciehp must ignore the value read from
it.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/hotplug/pciehp_hpc.c

index b643ca13e4f128b14ad8fe1eea1cff90506bf47c..22b88cb17a07c0c3af04b54a042b8e9d65710c83 100644 (file)
@@ -419,8 +419,7 @@ static int hpc_check_lnk_status(struct controller *ctrl)
        }
 
        ctrl_dbg(ctrl, "%s: lnk_status = %x\n", __func__, lnk_status);
-       if ( (lnk_status & LNK_TRN) || (lnk_status & LNK_TRN_ERR) ||
-               !(lnk_status & NEG_LINK_WD)) {
+       if ((lnk_status & LNK_TRN) || !(lnk_status & NEG_LINK_WD)) {
                ctrl_err(ctrl, "Link Training Error occurs \n");
                retval = -1;
                return retval;