gpio: xgene: fix type of variable containing error codes
authorAndrzej Hajda <a.hajda@samsung.com>
Tue, 23 Feb 2016 06:45:34 +0000 (07:45 +0100)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 25 Feb 2016 10:00:03 +0000 (11:00 +0100)
ret variable can contain error values and is compared with zero.
Its type must be signed.

The problem has been detected using coccinelle script
scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci

Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-xgene-sb.c

index b993b86958eddd506b51df5d8dfdc3f240b1a977..fd81ebc8d36560facf955d9d0ee8fa5f59412f55 100644 (file)
@@ -240,7 +240,7 @@ static const struct irq_domain_ops xgene_gpio_sb_domain_ops = {
 static int xgene_gpio_sb_probe(struct platform_device *pdev)
 {
        struct xgene_gpio_sb *priv;
-       u32 ret;
+       int ret;
        struct resource *res;
        void __iomem *regs;
        struct irq_domain *parent_domain = NULL;