thermal: rcar_thermal: don't open code of_device_get_match_data()
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Tue, 1 Mar 2016 16:38:31 +0000 (17:38 +0100)
committerEduardo Valentin <edubezval@gmail.com>
Tue, 8 Mar 2016 19:53:12 +0000 (11:53 -0800)
This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
drivers/thermal/rcar_thermal.c

index 0e735acea33afc7b8e747857b57046647d50e7d9..82daba09e1503a53d67e6f26705f80e563208fe7 100644 (file)
@@ -430,8 +430,7 @@ static int rcar_thermal_probe(struct platform_device *pdev)
        struct rcar_thermal_priv *priv;
        struct device *dev = &pdev->dev;
        struct resource *res, *irq;
-       const struct of_device_id *of_id = of_match_device(rcar_thermal_dt_ids, dev);
-       unsigned long of_data = (unsigned long)of_id->data;
+       unsigned long of_data = (unsigned long)of_device_get_match_data(dev);
        int mres = 0;
        int i;
        int ret = -ENODEV;